Re: [PATCH net v2 0/4] selftests: openvswitch: Minor fixes for some systems

From: Simon Horman
Date: Fri Oct 13 2023 - 16:06:37 EST


On Wed, Oct 11, 2023 at 03:49:35PM -0400, Aaron Conole wrote:
> A number of corner cases were caught when trying to run the selftests on
> older systems. Missed skip conditions, some error cases, and outdated
> python setups would all report failures but the issue would actually be
> related to some other condition rather than the selftest suite.
>
> Address these individual cases.
>
> Aaron Conole (4):
> selftests: openvswitch: Add version check for pyroute2
> selftests: openvswitch: Catch cases where the tests are killed
> selftests: openvswitch: Skip drop testing on older kernels
> selftests: openvswitch: Fix the ct_tuple for v4
>
> .../selftests/net/openvswitch/openvswitch.sh | 21 +++++++-
> .../selftests/net/openvswitch/ovs-dpctl.py | 48 ++++++++++++++++++-
> 2 files changed, 66 insertions(+), 3 deletions(-)

Thanks Aaron,

this looks like a good incremental improvement to me.

For series,

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>