Re: [PATCH] staging: qlge: Add bool type to qlge_idc_wait()

From: Nam Cao
Date: Sat Oct 14 2023 - 03:14:44 EST


On Sat, Oct 14, 2023 at 08:58:13AM +0200, Nam Cao wrote:
> On Sat, Oct 14, 2023 at 07:11:59AM +0100, Gilbert Adikankwu wrote:
> > Reported by checkpatch:
> >
> > WARNING: else is not generally useful after a break or return
> >
>
> What checkpatch is telling you here is that the "else" is redundant and
> can be removed. Although your patch suppresses the warning, it makes the
> code messier :(

Ah wait, after reading Julia's comment, I realize that the "else" is not
redundant at all. Seems like checkpatch.pl is lying. So ignore what I
said.