Re: [PATCH 1/3] drivers: usb: Fix block comments whose trailing */ was not on a separate line

[Jonathan Bergh]

On Sun, Oct 01, 2023 at 08:06:06AM +0200, Greg KH wrote:
> On Sat, Sep 30, 2023 at 10:36:46PM +0200, Jonathan Bergh wrote:
> > Fixed various instances where block comments trailing */ where not on a
> > separate line and should be.
> >
> > Signed-off-by: Jonathan Bergh <bergh.jonathan@xxxxxxxxx>
> > ---
> >  drivers/usb/atm/cxacru.c | 12 ++++++++----
> >  1 file changed, 8 insertions(+), 4 deletions(-)

Hi Greg, thanks a lot

> Your subject line for these patches is not correct, please fix up.

Thanks, will do.

> And the patches are not properly threaded, what happened in your email
> client?

Ok thanks, I used the same process as last time but will check it out.

> And finally, why make coding style changes outside of drivers/staging/?
> Did you get the maintainer's approval to do so before taking the time?
> Usually most maintainers do not want these so always ask before doing
> so, or just stick with drivers/staging/ to learn how the process works
> first please.

Ok! Thanks! Would you like these patches? I'd be happy to resend
them. Hopefully (like the guy you mentioned in your talk) unless they
screw something up, are seen as making a (postive) contribution!

cheers!
jon


> thanks,
>
> greg k-h