Re: [PATCH net-next v2 2/5] dt-bindings: marvell: Add Marvell MV88E6060 DSA schema

[Andrew Lunn]

> +                port@5 {
> +                    reg = <5>;
> +                    phy-mode = "rgmii-id";

It is a Fast Ethernet switch, so it will not be using Reduced Gigabit
MII. 'rev-mii' would be a better choice.

> +                    ethernet = <&ethc>;
> +                    label = "cpu";

label = "cpu" is deprecated, so you probably don't want it in an
example.


    Andrew

---
pw-bot: cr