Re: [PATCH] rtc: pcf85363: fix wrong mask/val parameters in regmap_update_bits call

[Alexandre Belloni]

On Fri, 13 Oct 2023 16:34:21 +0200, Javier Carrasco wrote:
> The current implementation passes PIN_IO_INTA_OUT (2) as a mask and
> PIN_IO_INTAPM (GENMASK(1, 0)) as a value.
> Swap the variables to assign mask and value the right way.
> 
> This error was first introduced with the alarm support. For better or
> worse it worked as expected because 0x02 was applied as a mask to 0x03,
> resulting 0x02 anyway. This will of course not work for any other value.
> 
> [...]

Applied, thanks!

[1/1] rtc: pcf85363: fix wrong mask/val parameters in regmap_update_bits call
      commit: 2be36c09b6b07306be33519e1aa70d2e2a2161bb

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com