Re: [PATCH V2 4/4] clk: meson: c3: add c3 clock peripherals controller driver

[Xianwei Zhao]

Hi Stephen & Jerome,
       Thanks for your reply.

On 2023/10/14 06:01, Stephen Boyd wrote:
> [ EXTERNAL EMAIL ]
>
> Quoting Jerome Brunet (2023-10-13 00:38:14)
> > On Thu 12 Oct 2023 at 16:51, Stephen Boyd <sboyd@xxxxxxxxxx> wrote:
> >
> > > Quoting Xianwei Zhao (2023-10-09 23:29:17)
> > > > diff --git a/drivers/clk/meson/Kconfig b/drivers/clk/meson/Kconfig
> > > > index 76be4bbd2afb..c8d59d28c8ff 100644
> > > > --- a/drivers/clk/meson/Kconfig
> > > > +++ b/drivers/clk/meson/Kconfig
> > > > @@ -140,6 +140,19 @@ config COMMON_CLK_C3_PLL
> > > >            Say Y if you want the board to work, because PLLs are the parent of most
> > > >            peripherals.
> > > >
> > > > +config COMMON_CLK_C3_PERIPHERALS
> > > > +       tristate "Amlogic C3 peripherals clock controller"
> > > > +       default y
> > >
> > > Why are these default y? They should depend on something like ARM64 and
> > > even then I don't see why we want to enable them by default if we're
> > > building the ARM64 kernel.
> >
> > Should indeed depend on ARM64.
>
> Cool. >
Will add depend on ARM64  in next version.
> > Those are the main clock controllers. Like for other AML SoC families,
> > they are necessary to boot the device which is why they use 'default y'
> >
> > Is it a problem ?
> >
> > The whole meson directory depends on ARCH_MESON, so the drivers will go
> > away if Amlogic support is removed on ARM64.
>
> No it isn't a problem if the entire section is implicitly depending on
> ARCH_MESON.