Re: [PATCH V4 2/4] xen: irqfd: Use _IOW instead of the internal _IOC() macro

[Juergen Gross]

On 16.10.23 09:11, Viresh Kumar wrote:
> _IOC() an internal helper that we should not use in driver code.  In
> particular, we got the data direction wrong here, which breaks a number
> of tools, as having "_IOC_NONE" should never be paired with a nonzero
> size.
>
> Use _IOW() instead.
>
> Fixes: f8941e6c4c71 ("xen: privcmd: Add support for irqfd")
> Reported-by: Arnd Bergmann <arnd@xxxxxxxxxx>
> Closes: https://lore.kernel.org/all/268a2031-63b8-4c7d-b1e5-8ab83ca80b4a@xxxxxxxxxxxxxxxx/
> Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>

Reviewed-by: Juergen Gross <jgross@xxxxxxxx>


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature