Re: [PATCH v6] cpufreq: qcom-nvmem: add support for IPQ8074

From: Dmitry Baryshkov
Date: Mon Oct 16 2023 - 04:36:26 EST


On Mon, 16 Oct 2023 at 11:29, Robert Marko <robimarko@xxxxxxxxx> wrote:
>
> On Mon, 16 Oct 2023 at 10:22, Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> >
> > On 16-10-23, 09:02, Viresh Kumar wrote:
> > > On 13-10-23, 19:20, Robert Marko wrote:
> > > > IPQ8074 comes in 3 families:
> > > > * IPQ8070A/IPQ8071A (Acorn) up to 1.4GHz
> > > > * IPQ8172/IPQ8173/IPQ8174 (Oak) up to 1.4GHz
> > > > * IPQ8072A/IPQ8074A/IPQ8076A/IPQ8078A (Hawkeye) up to 2.2GHz
> > > >
> > > > So, in order to be able to share one OPP table lets add support for IPQ8074
> > > > family based of SMEM SoC ID-s as speedbin fuse is always 0 on IPQ8074.
> > > >
> > > > IPQ8074 compatible is blacklisted from DT platdev as the cpufreq device
> > > > will get created by NVMEM CPUFreq driver.
> > > >
> > > > Signed-off-by: Robert Marko <robimarko@xxxxxxxxx>
> > > > Acked-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> > > > ---
> > > > Changes in v6:
> > > > * Split IPQ8074 from the IPQ8064 as IPQ8064 has additional dependencies.
> > >
> > > Applied. Thanks.
> >
> > And it failed to build, please fix it. Dropped from my tree now.
>
> I am looking at the error and it should not happen as the ID-s have
> been in linux-next for a month now:
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/include/dt-bindings/arm/qcom,ids.h?h=next-20231016&id=b8c889bef9797a58b8b5aad23875cc4d04b3efd3
>
> They are also part of Bjorns 6.7 driver PR:
> https://lore.kernel.org/all/20231015204014.855672-1-andersson@xxxxxxxxxx/T/

But Bjorn's tree isn't a part of the cpufreq tree. In such cases it is
typical to ask first maintainer to create an immutable branch / tag,
which can later be also merged into another tree without going into
troubles of merging the whole tree of the irrelevant subsystem.


--
With best wishes
Dmitry