Re: [PATCH net-next v3 3/6] dt-bindings: net: mvusb: Fix up DSA example

[Vladimir Oltean]

On Mon, Oct 16, 2023 at 11:12:56AM +0200, Linus Walleij wrote:
> When adding a proper schema for the Marvell mx88e6xxx switch,
> the scripts start complaining about this embedded example:
> 
>   dtschema/dtc warnings/errors:
>   net/marvell,mvusb.example.dtb: switch@0: ports: '#address-cells'
>   is a required property
>   from schema $id: http://devicetree.org/schemas/net/dsa/marvell,mv88e6xxx.yaml#
>   net/marvell,mvusb.example.dtb: switch@0: ports: '#size-cells'
>   is a required property
>   from schema $id: http://devicetree.org/schemas/net/dsa/marvell,mv88e6xxx.yaml#
> 
> Fix this up by extending the example.
> 
> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/net/marvell,mvusb.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/marvell,mvusb.yaml b/Documentation/devicetree/bindings/net/marvell,mvusb.yaml
> index 3a3325168048..ee677cf7df4e 100644
> --- a/Documentation/devicetree/bindings/net/marvell,mvusb.yaml
> +++ b/Documentation/devicetree/bindings/net/marvell,mvusb.yaml
> @@ -56,6 +56,12 @@ examples:
>  
>                              ports {
>                                      /* Port definitions */
> +                                    #address-cells = <1>;
> +                                    #size-cells = <0>;
> +
> +                                    port@0 {
> +                                            reg = <0>;
> +                                    };

Could you just skip defining any port, and just leave the /* Port definitions */
comment at the end (after the newly added #address-cells and #size-cells)?
This example is more about the USB adapter, not about the switch.

>                              };
>  
>                              mdio {
> 
> -- 
> 2.34.1
>