Re: [PATCHv2] efi/unaccepted: Fix soft lockups caused by parallel memory acceptance

From: Kirill A. Shutemov
Date: Mon Oct 16 2023 - 17:39:50 EST


On Mon, Oct 16, 2023 at 06:55:41PM +0100, Matthew Wilcox wrote:
> On Mon, Oct 16, 2023 at 07:31:22PM +0300, Kirill A. Shutemov wrote:
> > v2:
> > - Fix deadlock (Vlastimil);
> > - Fix comments (Vlastimil);
> > - s/cond_resched()/cpu_relax()/ -- cond_resched() cannot be called
> > from atomic context;
>
> Isn't there an implicit cpu_relax() while we're spinning? Does this
> really accomplish anything?

You are right. It is useless. I will drop it in v3.

--
Kiryl Shutsemau / Kirill A. Shutemov