Re: [PATCH net-next v4 5/9] net: dsa: microchip: ksz9477: Add Wake on Magic Packet support

From: Andrew Lunn
Date: Mon Oct 16 2023 - 21:42:55 EST


> - wol->supported = WAKE_PHY;
> + wol->supported = WAKE_PHY | WAKE_MAGIC;

It is clearly racy, but maybe try a ksz_switch_macaddr_get() and only
if it is successful add WAKE_MAGIC. Then do a
ksz_switch_macaddr_put(). Given the limitations of the hardware, it
might help the user understand what the hardware can do.

But this is not a must.

Andrew