Re: [PATH v5 3/3] iommu/vt-d: debugfs: Support dumping a specified page table

From: Liu, Jingqi
Date: Mon Oct 16 2023 - 23:02:37 EST



On 10/16/2023 11:04 AM, Baolu Lu wrote:
On 10/13/23 9:58 PM, Jingqi Liu wrote:

......
+        if (scalable) {    /* scalable mode */
+            struct pasid_dir_entry *dir_tbl, *dir_entry;
+            struct pasid_entry *pasid_tbl, *pasid_tbl_entry;
+            u16 pasid_dir_size, dir_idx, tbl_idx, pgtt;
+            u64 pasid_dir_ptr;

0day robot complained:

   drivers/iommu/intel/debugfs.c: In function 'domain_translation_struct_show':
>> drivers/iommu/intel/debugfs.c:401:29: warning: variable 'pasid_dir_size' set but not used [-Wunused-but-set-variable]
     401 |                         u16 pasid_dir_size, dir_idx, tbl_idx, pgtt;
         |                             ^~~~~~~~~~~~~~

I have removed pasid_dir_size and queue the whole series for v6.7.

Thanks Baolu.
Indeed. It's an unused variable.

BR,
Jingqi
Thank you!

Best regards,
baolu