RE: [PATCH V2] Consider inflight IO in io accounting for high latency devices

[Gulam Mohamed]

Hi Bart,

       Thanks for the review. I agree, for low latency devices if they have single hardware queue, this patch will have significant impact. Can you please let me know about what kind of low latency devices will have a single queue (just for my knowledge)?
Also I would be grateful if you have any suggestions to fix this issue?

Regards,
Gulam Mohamed.

-----Original Message-----
From: Bart Van Assche <bvanassche@xxxxxxx> 
Sent: Tuesday, October 17, 2023 2:46 AM
To: Gulam Mohamed <gulam.mohamed@xxxxxxxxxx>; axboe@xxxxxxxxx; linux-block@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH V2] Consider inflight IO in io accounting for high latency devices

On 10/16/23 13:01, Gulam Mohamed wrote:
> [GULAM]: Yes, it will be called for every submitted bio but for the 
> high latency devices it will not have much impact. This is indicated 
> by the latency figures I provided in the review mail, with and without 
> our patch.

Calling tag iteration code from the hot path is wrong.

There are more devices than only hard disks that have a single hardware queue, e.g. certain SSDs. I'm pretty sure that this patch will have a significant negative performance impact for such devices.

Thanks,

Bart.