Re: [PATCH v8 18/23] drm/mediatek: Add Padding to OVL adaptor

[Shawn Sung (宋孝謙)]

Hi Angelo,

On Tue, 2023-10-17 at 11:47 +0200, AngeloGioacchino Del Regno wrote:
> Il 16/10/23 12:40, Hsiao Chien Sung ha scritto:
> > Add MT8188 Padding to OVL adaptor to probe the driver.
> > 
> > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.
> > ---
> >   .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c   | 26
> > +++++++++++++++++++
> >   1 file changed, 26 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> > b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> > index 354ba6186166..b80425360e76 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> > @@ -29,6 +29,7 @@ enum mtk_ovl_adaptor_comp_type {
> >   	OVL_ADAPTOR_TYPE_ETHDR,
> >   	OVL_ADAPTOR_TYPE_MDP_RDMA,
> >   	OVL_ADAPTOR_TYPE_MERGE,
> > +	OVL_ADAPTOR_TYPE_PADDING,
> >   	OVL_ADAPTOR_TYPE_NUM,
> >   };
> >   
> > @@ -46,6 +47,14 @@ enum mtk_ovl_adaptor_comp_id {
> >   	OVL_ADAPTOR_MERGE1,
> >   	OVL_ADAPTOR_MERGE2,
> >   	OVL_ADAPTOR_MERGE3,
> > +	OVL_ADAPTOR_PADDING0,
> > +	OVL_ADAPTOR_PADDING1,
> > +	OVL_ADAPTOR_PADDING2,
> > +	OVL_ADAPTOR_PADDING3,
> > +	OVL_ADAPTOR_PADDING4,
> > +	OVL_ADAPTOR_PADDING5,
> > +	OVL_ADAPTOR_PADDING6,
> > +	OVL_ADAPTOR_PADDING7,
> >   	OVL_ADAPTOR_ID_MAX
> >   };
> >   
> > @@ -66,6 +75,7 @@ static const char * const
> > private_comp_stem[OVL_ADAPTOR_TYPE_NUM] = {
> >   	[OVL_ADAPTOR_TYPE_ETHDR]	= "ethdr",
> >   	[OVL_ADAPTOR_TYPE_MDP_RDMA]	= "vdo1-rdma",
> >   	[OVL_ADAPTOR_TYPE_MERGE]	= "merge",
> > +	[OVL_ADAPTOR_TYPE_PADDING]	= "padding",
> >   };
> >   
> >   static const struct mtk_ddp_comp_funcs _ethdr = {
> > @@ -80,6 +90,13 @@ static const struct mtk_ddp_comp_funcs _merge =
> > {
> >   	.clk_disable = mtk_merge_clk_disable,
> >   };
> >   
> > +static const struct mtk_ddp_comp_funcs _padding = {
> 
> Please, _padding -> padding or mtk_padding
> 
> 
> Thanks,
> Angelo

Got it. Will change in the next version.

Thanks,
Shawn