Re: [PATCH v8 15/23] drm/mediatek: Manage component's clock with function pointers

[AngeloGioacchino Del Regno]

Il 17/10/23 12:50, Shawn Sung (宋孝謙) ha scritto:
> Hi Angelo,
>
> On Tue, 2023-10-17 at 11:47 +0200, AngeloGioacchino Del Regno wrote:
> > Il 16/10/23 12:40, Hsiao Chien Sung ha scritto:
> > > By registering component related functions to the pointers,
> > > we can easily manage them within a for-loop and simplify the
> > > logic of clock control significantly.
> > >
> > > Reviewed-by: CK Hu <ck.hu@xxxxxxxxxxxx>
> > > Signed-off-by: Hsiao Chien Sung <shawn.sung@xxxxxxxxxxxx>
> > > ---
> > >    .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c   | 111 +++++++----
> > > -------
> > >    1 file changed, 44 insertions(+), 67 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> > > b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> > > index 60e5dfe9ef0d..fffef2a4f919 100644
> > > --- a/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> > > +++ b/drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
> > > @@ -53,6 +53,7 @@ struct ovl_adaptor_comp_match {
> > >    	enum mtk_ovl_adaptor_comp_type type;
> > >    	enum mtk_ddp_comp_id comp_id;
> > >    	int alias_id;
> > > +	const struct mtk_ddp_comp_funcs *funcs;
> > >    };
> > >    
> > >    struct mtk_disp_ovl_adaptor {
> > > @@ -67,20 +68,35 @@ static const char * const
> > > private_comp_stem[OVL_ADAPTOR_TYPE_NUM] = {
> > >    	[OVL_ADAPTOR_TYPE_MERGE]	= "merge",
> > >    };
> > >    
> > > +static const struct mtk_ddp_comp_funcs _ethdr = {
> >
> > Sorry I just noticed that; can you please remove the leading "_" from
> > all
> > of those?
> >
> > _ethdr -> ethdr or mtk_ethdr
> > _merge -> merge or mtk_merge
> > _rdma  -> rdma  or mtk_rdma
> >
> > Thanks,
> > Angelo
>
> Sure. Will do in the next version.
> The reason I didn't use mtk_* is simply because of the column width
> will exceed 100 characaters.

Okay that would not be good, I guess that just `ethdr`, `merge`, `rdma` will
be fine then.

Cheers,
Angelo

> Thanks,
> Shawn