drivers/gpu/drm/scheduler/sched_main.c:266: warning: Function parameter or member 'result' not described in 'drm_sched_job_done'
From: kernel test robot
Date: Tue Oct 17 2023 - 08:15:29 EST
Hi Christian,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 213f891525c222e8ed145ce1ce7ae1f47921cb9c
commit: 539f9ee4b52a8bec95ff064e22dd2fb1e258e818 drm/scheduler: properly forward fence errors
date: 6 months ago
config: x86_64-buildonly-randconfig-004-20230906 (https://download.01.org/0day-ci/archive/20231017/202310172018.eaPyawVC-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310172018.eaPyawVC-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310172018.eaPyawVC-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/gpu/drm/scheduler/sched_main.c:266: warning: Function parameter or member 'result' not described in 'drm_sched_job_done'
vim +266 drivers/gpu/drm/scheduler/sched_main.c
08fb97de03aa22 Andrey Grodzovsky 2022-09-30 258
71173e787cab9d Luben Tuikov 2020-12-03 259 /**
71173e787cab9d Luben Tuikov 2020-12-03 260 * drm_sched_job_done - complete a job
71173e787cab9d Luben Tuikov 2020-12-03 261 * @s_job: pointer to the job which is done
71173e787cab9d Luben Tuikov 2020-12-03 262 *
71173e787cab9d Luben Tuikov 2020-12-03 263 * Finish the job's fence and wake up the worker thread.
71173e787cab9d Luben Tuikov 2020-12-03 264 */
539f9ee4b52a8b Christian König 2023-04-17 265 static void drm_sched_job_done(struct drm_sched_job *s_job, int result)
71173e787cab9d Luben Tuikov 2020-12-03 @266 {
71173e787cab9d Luben Tuikov 2020-12-03 267 struct drm_sched_fence *s_fence = s_job->s_fence;
71173e787cab9d Luben Tuikov 2020-12-03 268 struct drm_gpu_scheduler *sched = s_fence->sched;
71173e787cab9d Luben Tuikov 2020-12-03 269
71173e787cab9d Luben Tuikov 2020-12-03 270 atomic_dec(&sched->hw_rq_count);
f2f12eb9c32bc7 Christian König 2021-02-02 271 atomic_dec(sched->score);
71173e787cab9d Luben Tuikov 2020-12-03 272
71173e787cab9d Luben Tuikov 2020-12-03 273 trace_drm_sched_process_job(s_fence);
71173e787cab9d Luben Tuikov 2020-12-03 274
71173e787cab9d Luben Tuikov 2020-12-03 275 dma_fence_get(&s_fence->finished);
539f9ee4b52a8b Christian König 2023-04-17 276 drm_sched_fence_finished(s_fence, result);
71173e787cab9d Luben Tuikov 2020-12-03 277 dma_fence_put(&s_fence->finished);
71173e787cab9d Luben Tuikov 2020-12-03 278 wake_up_interruptible(&sched->wake_up_worker);
71173e787cab9d Luben Tuikov 2020-12-03 279 }
71173e787cab9d Luben Tuikov 2020-12-03 280
:::::: The code at line 266 was first introduced by commit
:::::: 71173e787cab9db4ca1fa6229477cb3d254bc285 drm/scheduler: Essentialize the job done callback
:::::: TO: Luben Tuikov <luben.tuikov@xxxxxxx>
:::::: CC: Christian König <christian.koenig@xxxxxxx>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki