Re: [PATCH] drm/msm/a6xx: add QMP dependency

From: Konrad Dybcio
Date: Tue Oct 17 2023 - 08:25:09 EST




On 10/16/23 22:04, Arnd Bergmann wrote:
From: Arnd Bergmann <arnd@xxxxxxxx>

When QMP is in a loadable module, the A6xx GPU driver fails to link
as built-in:

x86_64-linux-ld: drivers/gpu/drm/msm/adreno/a6xx_gmu.o: in function `a6xx_gmu_resume':
a6xx_gmu.c:(.text+0xd62): undefined reference to `qmp_send'

Add the usual dependency that still allows compiling without QMP but
otherwise avoids the broken combination of options.

Fixes: 88a0997f2f949 ("drm/msm/a6xx: Send ACD state to QMP at GMU resume")
Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
---
Right, thanks!

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad