Re: [PATCH v2 8/8] LoongArch: Add ORC unwinder support
From: Tiezhu Yang
Date: Tue Oct 17 2023 - 08:37:14 EST
On 10/14/2023 07:37 PM, Huacai Chen wrote:
+CC Jinyang
On Sat, Oct 14, 2023 at 5:21 PM Tiezhu Yang <yangtiezhu@xxxxxxxxxxx> wrote:
...
diff --git a/arch/loongarch/power/Makefile b/arch/loongarch/power/Makefile
index 58151d0..bbd1d47 100644
--- a/arch/loongarch/power/Makefile
+++ b/arch/loongarch/power/Makefile
@@ -1,3 +1,5 @@
+OBJECT_FILES_NON_STANDARD_suspend_asm.o := y
hibernate_asm.o has no problem?
Yes, only suspend_asm.o has one warning, just ignore it.
What kind of warning? When I submitted the suspend patch, Jinyang told
me that with his changes loongarch_suspend_enter() can be a regular
function.
Like this:
AS arch/loongarch/power/suspend_asm.o
arch/loongarch/power/suspend_asm.o: warning: objtool:
loongarch_suspend_enter+0x6c: unreachable instruction
[fedora@linux 6.6.test]$ objdump -M no-aliases -D
arch/loongarch/power/suspend_asm.o
0000000000000ffc <loongarch_suspend_enter>:
ffc: 02fb0063 addi.d $sp, $sp, -320
1000: 29c02061 st.d $ra, $sp, 8
1004: 29c04062 st.d $tp, $sp, 16
1008: 29c06063 st.d $sp, $sp, 24
100c: 29c08064 st.d $a0, $sp, 32
1010: 29c2a075 st.d $r21, $sp, 168
1014: 29c2c076 st.d $fp, $sp, 176
1018: 29c2e077 st.d $s0, $sp, 184
101c: 29c30078 st.d $s1, $sp, 192
1020: 29c32079 st.d $s2, $sp, 200
1024: 29c3407a st.d $s3, $sp, 208
1028: 29c3607b st.d $s4, $sp, 216
102c: 29c3807c st.d $s5, $sp, 224
1030: 29c3a07d st.d $s6, $sp, 232
1034: 29c3c07e st.d $s7, $sp, 240
1038: 29c3e07f st.d $s8, $sp, 248
103c: 1a00000c pcalau12i $t0, 0
1040: 02c0018c addi.d $t0, $t0, 0
1044: 29c00183 st.d $sp, $t0, 0
1048: 54000000 bl 0 # 1048 <loongarch_suspend_enter+0x4c>
104c: 02c00065 addi.d $a1, $sp, 0
1050: 1a000004 pcalau12i $a0, 0
1054: 02c00084 addi.d $a0, $a0, 0
1058: 1a00000c pcalau12i $t0, 0
105c: 02c0018c addi.d $t0, $t0, 0
1060: 28c0018c ld.d $t0, $t0, 0
1064: 4c000184 jirl $a0, $t0, 0
0000000000001068 <loongarch_wakeup_start>:
1068: 0380040c ori $t0, $zero, 0x1
106c: 0320018c lu52i.d $t0, $t0, -2048
1070: 0406002c csrwr $t0, 0x180
1074: 0380440c ori $t0, $zero, 0x11
1078: 0324018c lu52i.d $t0, $t0, -1792
107c: 0406042c csrwr $t0, 0x181
1080: 0324000c lu52i.d $t0, $zero, -1792
1084: 1800000d pcaddi $t1, 0
1088: 0015358c or $t0, $t0, $t1
108c: 4c000d80 jirl $zero, $t0, 12
1090: 0382c00c ori $t0, $zero, 0xb0
1094: 0400002c csrwr $t0, 0x0
1098: 1a00000c pcalau12i $t0, 0
109c: 02c0018c addi.d $t0, $t0, 0
10a0: 28c00183 ld.d $sp, $t0, 0
10a4: 28c02061 ld.d $ra, $sp, 8
10a8: 28c04062 ld.d $tp, $sp, 16
10ac: 28c06063 ld.d $sp, $sp, 24
10b0: 28c08064 ld.d $a0, $sp, 32
10b4: 28c2a075 ld.d $r21, $sp, 168
10b8: 28c2c076 ld.d $fp, $sp, 176
10bc: 28c2e077 ld.d $s0, $sp, 184
10c0: 28c30078 ld.d $s1, $sp, 192
10c4: 28c32079 ld.d $s2, $sp, 200
10c8: 28c3407a ld.d $s3, $sp, 208
10cc: 28c3607b ld.d $s4, $sp, 216
10d0: 28c3807c ld.d $s5, $sp, 224
10d4: 28c3a07d ld.d $s6, $sp, 232
10d8: 28c3c07e ld.d $s7, $sp, 240
10dc: 28c3e07f ld.d $s8, $sp, 248
10e0: 02c50063 addi.d $sp, $sp, 320
10e4: 4c000020 jirl $zero, $ra, 0
It need to modify jirl decoder to handle the following instruction:
1064: 4c000184 jirl $a0, $t0, 0
Thanks,
Tiezhu