Re: [PATCH 4/6] arm64: dts: qcom: starqltechn: enable more features

[Krzysztof Kozlowski]

On 18/10/2023 14:30, Dzmitry Sankouski wrote:
> - enable usb 2.0
> - enable debug uart (uart9)
> - enable touchscreen
> - enable ipa so that we can bring up mobile data
> 
> Signed-off-by: Dzmitry Sankouski <dsankouski@xxxxxxxxx>


>  &usb_1_dwc3 {
>  	/* Until we have Type C hooked up we'll force this as peripheral. */
>  	dr_mode = "peripheral";
> +
> +	maximum-speed = "high-speed";
>  };
>  
>  &usb_1_hsphy {
> @@ -444,4 +580,53 @@ sd_card_det_n_state: sd-card-det-n-state {
>  		function = "gpio";
>  		bias-pull-up;
>  	};
> +
> +	s2dos05_irq: s2dos05_irq {

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

Best regards,
Krzysztof