[PATCH net-next v3 00/11] devlink: retain error in struct devlink_fmsg
From: Przemek Kitszel
Date: Wed Oct 18 2023 - 16:27:38 EST
Extend devlink fmsg to retain error (patch 1),
so drivers could omit error checks after devlink_fmsg_*() (patches 2-10),
and finally enforce future uses to follow this practice by change to
return void (patch 11)
Note that it was compile tested only.
bloat-o-meter for whole series:
add/remove: 8/18 grow/shrink: 23/40 up/down: 2017/-5833 (-3816)
changelog:
v3: set err to correct value, thanks to Simon and smatch
(mlx5 patch, final patch);
v2: extend series by two more drivers (qed, qlge);
add final cleanup patch, since now whole series should be merged in
one part (thanks Jiri for encouragement here);
v1:
https://lore.kernel.org/netdev/20231010104318.3571791-3-przemyslaw.kitszel@xxxxxxxxx
v2:
https://lore.kernel.org/netdev/20231017105341.415466-1-przemyslaw.kitszel@xxxxxxxxx
Przemek Kitszel (11):
devlink: retain error in struct devlink_fmsg
netdevsim: devlink health: use retained error fmsg API
pds_core: devlink health: use retained error fmsg API
bnxt_en: devlink health: use retained error fmsg API
hinic: devlink health: use retained error fmsg API
octeontx2-af: devlink health: use retained error fmsg API
mlxsw: core: devlink health: use retained error fmsg API
net/mlx5: devlink health: use retained error fmsg API
qed: devlink health: use retained error fmsg API
staging: qlge: devlink health: use retained error fmsg API
devlink: convert most of devlink_fmsg_*() to return void
drivers/net/ethernet/amd/pds_core/devlink.c | 29 +-
.../net/ethernet/broadcom/bnxt/bnxt_devlink.c | 93 ++--
.../net/ethernet/huawei/hinic/hinic_devlink.c | 217 +++-----
.../marvell/octeontx2/af/rvu_devlink.c | 464 +++++-------------
.../mellanox/mlx5/core/diag/fw_tracer.c | 49 +-
.../mellanox/mlx5/core/diag/reporter_vnic.c | 118 ++---
.../mellanox/mlx5/core/diag/reporter_vnic.h | 6 +-
.../ethernet/mellanox/mlx5/core/en/health.c | 187 ++-----
.../ethernet/mellanox/mlx5/core/en/health.h | 14 +-
.../mellanox/mlx5/core/en/reporter_rx.c | 426 ++++------------
.../mellanox/mlx5/core/en/reporter_tx.c | 346 ++++---------
.../net/ethernet/mellanox/mlx5/core/en_rep.c | 5 +-
.../net/ethernet/mellanox/mlx5/core/health.c | 127 ++---
drivers/net/ethernet/mellanox/mlxsw/core.c | 171 ++-----
drivers/net/ethernet/qlogic/qed/qed_devlink.c | 6 +-
drivers/net/netdevsim/health.c | 118 ++---
drivers/staging/qlge/qlge_devlink.c | 60 +--
include/net/devlink.h | 60 +--
net/devlink/health.c | 387 +++++----------
19 files changed, 823 insertions(+), 2060 deletions(-)
--
2.38.1