Re: [PATCH v5 3/3] media: imx-jpeg: Add vendor prefix in slot property

[ming qian]

Hi Krzysztof,

> > From: Ming Qian <ming.qian@xxxxxxx>
> >
> > The slot property isn't generic property, add vendor prefix. Change the
> > property name to nxp,slot.
> >
> > Fixes: 53ebeea50599 ("media: imx-jpeg: Support to assign slot for encoder/decoder")
> > Signed-off-by: Ming Qian <ming.qian@xxxxxxx>
> > ---
> > v5
> > - add vender prefix, change property slot to nxp,slot
> >
> > v4
> > - nothing changed here, just modify the bindings and dts
> >
> > v3
> > - nothing changed here, just modify the bindings and dts
> >
> > v2
> > - nothing changed here, just modify the bindings and dts
> >
> >   drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> > index 64112b63298c..f8b99a292ad1 100644
> > --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> > +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> > @@ -2762,7 +2762,7 @@ static int mxc_jpeg_probe(struct platform_device *pdev)
> >   	if (IS_ERR(jpeg->base_reg))
> >   		return PTR_ERR(jpeg->base_reg);
> >   
> > -	ret = of_property_read_u32_index(pdev->dev.of_node, "slot", 0, &jpeg->slot_data.slot);
>
> How did it appear in the code and in the DTS without bindings...
>
> Best regards,
> Krzysztof

In the beginning, I only made the patch set of code and dts, the code
patch can work without dts patch due to the default value. The code
patch is merged to media_tree, but mark the dts patch as ´Not
Applicable´. After that, I sent the dts patch again, but maintainer
reminds me that I need to change the binding too. So I made this patch
set. And I guess the dts patch was merged by mistake.

best regards,
Ming