Re: [PATCH v10 20/24] drm/mediatek: Add Padding to OVL adaptor

[AngeloGioacchino Del Regno]

Il 19/10/23 11:20, Shawn Sung (宋孝謙) ha scritto:
> Hi Angelo,
>
> On Thu, 2023-10-19 at 11:10 +0200, AngeloGioacchino Del Regno wrote:
> > >    static const struct of_device_id mtk_ovl_adaptor_comp_dt_ids[] =
> > > {
> > > +	{ .compatible = "mediatek,mt8188-padding", .data = (void
> > > *)OVL_ADAPTOR_TYPE_PADDING },
> >
> > Uhm, for consistency I'd call this "mediatek,mt8188-disp-padding"
> > (you don't have
> > to drop Reviewed-by tags for such a change, not here and not in the
> > yaml commit),
> > but it's fine if you have reasons against that.
> >
> > So, regardless of this being changed or not
> >
> > Reviewed-by: AngeloGioacchino Del Regno <
> > angelogioacchino.delregno@xxxxxxxxxxxxx>
> >
> > >    	{ .compatible = "mediatek,mt8195-disp-ethdr", .data = (void
> > > *)OVL_ADAPTOR_TYPE_ETHDR },
> > >    	{ .compatible = "mediatek,mt8195-disp-merge", .data = (void
> > > *)OVL_ADAPTOR_TYPE_MERGE },
> > >    	{ .compatible = "mediatek,mt8195-vdo1-rdma", .data = (void
> > > *)OVL_ADAPTOR_TYPE_MDP_RDMA },
>
> Thanks for pointing this out. Had changed Padding driver's name to
> "mtk-disp-padding", but I just notice that Padding will also be used by
> MDP and they will share the same driver with display. Should we change
> the name again or is it just fine to use "mtk-disp-padding"?

That's like many other components in MediaTek, so we can keep the mtk-disp-padding
name.... in devicetree, we will anyway use "mediatek,mt8195-mdp3-padding" as one of
the compatible string(s).

This is the only way that we have to actually distinguish between components used
for MDP3 and components used for the display subsystem, if we keep them "generic"
we won't understand what's going on in case of issues.

The driver name should contain "disp" for consistency with all of the component
drivers in mediatek-drm; if this wasn't in this folder, we could've dropped the
"disp" in the name, but that's not the case.

Consistency is #1.

Cheers,
Angelo

> Thanks,
> Shawn