Re: [PATCH net v1 1/1] ethtool: fix clearing of WoL flags

From: Michal Kubecek
Date: Thu Oct 19 2023 - 06:54:46 EST


On Thu, Oct 19, 2023 at 12:50:48PM +0200, Michal Kubecek wrote:
[...]
> @@ -490,6 +509,8 @@ ethnl_update_bitset32_verbose(u32 *bitmap, unsigned int nbits,
> *mod = true;
> }
> }
> + if (saved_bitmap)
> + *mod = ethnl_bitmap32_cmp(saved_bitmap, bitmap, nbits);
>
> ret = 0;
> out:

Oops, this should be

*mod = !ethnl_bitmap32_equal(saved_bitmap, bitmap, nbits);

Michal

Attachment: signature.asc
Description: PGP signature