Re: [PATCH v2 1/2] staging: qlge: Fix coding style in qlge.h
From: Nandha Kumar Singaram
Date: Thu Oct 19 2023 - 09:48:05 EST
On Thu, Oct 19, 2023 at 02:27:40PM +0200, Simon Horman wrote:
> On Wed, Oct 18, 2023 at 12:46:00PM -0700, Nandha Kumar Singaram wrote:
> > Replace all occurrnces of (1<<x) by BIT(x) to get rid of checkpatch.pl
> > "CHECK" output "Prefer using the BIT macro"
> >
> > Signed-off-by: Nandha Kumar Singaram <nandhakumar.singaram@xxxxxxxxx>
>
> Thanks Nandha,
>
> these changes look good to me.
> But I would like to ask if not updating
> Q_LEN_V and LEN_V is intentional.
Thanks for the review Simon.
I have already sent a patch for Q_LEN_V and LEN_V and it is accepted
by greg k-h, so didn't updated here.
regards,
Nandha Kumar Singaram