Re: [PATCH] fpga: disable KUnit test suites when module support is enabled

[Xu Yilun]

On Thu, Oct 19, 2023 at 07:33:08PM +0200, Greg KH wrote:
> On Thu, Oct 19, 2023 at 10:47:39PM +0800, Xu Yilun wrote:
> > On Wed, Oct 18, 2023 at 06:38:13PM +0200, Marco Pagani wrote:
> > > The fpga core currently assumes that all manager, bridge, and region
> > > devices have a parent device associated with a driver that can be used
> > > to take the module's refcount. This behavior causes the fpga test suites
> > > to crash with a null-ptr-deref since parent fake devices do not have a
> > > driver. This patch disables all fpga KUnit test suites when loadable
> > > module support is enabled until the fpga core is fixed. Test suites
> > > can still be run using the KUnit default UML kernel.
> > > 
> > > Signed-off-by: Marco Pagani <marpagan@xxxxxxxxxx>
> > 
> > LGTM, I've tested on my machine.
> > 
> > Acked-by: Xu Yilun <yilun.xu@xxxxxxxxx>
> > 
> > Hi Greg:
> > 
> > Could you help review and pull it in for 6.6-final if it's OK.
> > 
> > https://lore.kernel.org/linux-fpga/2023101825-ligament-undergrad-cc4d@gregkh/
> 
> Needs a "Fixes:" tag please, you can provide it here in this email
> thread and b4 will pick it up automatically for me.

Fixes: ccbc1c302115 ("fpga: add an initial KUnit suite for the FPGA Manager")

Thanks,
Yilun

> 
> thanks,
> 
> greg k-h