Re: [PATCH v2 2/2] mm:vmscan: the ref clean dirty folio skip unmap

From: zhiguojiang
Date: Thu Oct 19 2023 - 23:37:56 EST




在 2023/10/20 11:29, Matthew Wilcox 写道:
On Thu, Oct 19, 2023 at 09:42:11PM +0800, Zhiguo Jiang wrote:
+++ b/mm/vmscan.c
@@ -1225,7 +1225,10 @@ static unsigned int shrink_folio_list(struct list_head *folio_list,
stat->nr_ref_keep += nr_pages;
goto keep_locked;
case FOLIOREF_RECLAIM:
+ break;
case FOLIOREF_RECLAIM_CLEAN:
+ if (dirty)
+ goto activate_locked;
Why activate_locked and not keep_locked?
Hi,
This is  a mistake, should be keep_locked.