Re: [PATCH v2 3/6] powerpc/smp: Move shared_processor static key to smp.h

From: Michael Ellerman
Date: Fri Oct 20 2023 - 06:45:35 EST


Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx> writes:
> * Michael Ellerman <mpe@xxxxxxxxxxxxxx> [2023-10-19 15:41:40]:
>
>> Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx> writes:
>> > The ability to detect if the system is running in a shared processor
>> > mode is helpful in few more generic cases not just in
>> > paravirtualization.
>> > For example: At boot time, different scheduler/ topology flags may be
>> > set based on the processor mode. Hence move it to a more generic file.
>>
>> I'd rather you just included paravirt.h in the few files where you need it.
>
> I thought, detecting if a Processor was shared or not was more a
> smp/processor related than a paravirt related.

It's both really :)

It's definitely paravirt related though, because if we weren't
*para*virt then we wouldn't know there was a hypervisor at all :)

But having smaller more focused headers is preferable in general just
for mechanical reasons.

cheers