Re: [PATCH 1/2] nvme: common: make keyring and auth separate modules

[Hannes Reinecke]

On 10/20/23 15:05, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> When only the keyring module is included but auth is not, modpost
> complains about the lack of a module license tag:
>
> ERROR: modpost: missing MODULE_LICENSE() in drivers/nvme/common/nvme-common.o
>
> Address this by making both modules buildable standalone,
> removing the now unnecessary CONFIG_NVME_COMMON symbol
> in the process.
>
> Fixes: 9d77eb5277849 ("nvme-keyring: register '.nvme' keyring")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>   drivers/nvme/Makefile         | 2 +-
>   drivers/nvme/common/Kconfig   | 4 ++--
>   drivers/nvme/common/Makefile  | 7 ++++---
>   drivers/nvme/common/keyring.c | 2 ++
>   drivers/nvme/host/Kconfig     | 2 --
>   drivers/nvme/target/Kconfig   | 2 --
>   include/linux/nvme-keyring.h  | 2 +-
>   7 files changed, 10 insertions(+), 11 deletions(-)
Reviewed-by: Hannes Reinecke <hare@xxxxxxx>

Cheers,

Hannes