Re: [PATCH v3 1/2] misc: rtsx: add to support new card reader rts5264

[gregkh@xxxxxxxxxxxxxxxxxxx]

On Fri, Oct 20, 2023 at 08:13:46AM +0000, Ricky WU wrote:
> In order to support new chip rts5264, the definitions of some internal
> registers and workflow have to be modified.

That is fine, but that should be a single patch, right?

> Added rts5264.c rts5264.h for independent functions of the new chip rts5264

And then add new support in a new patch, this is still too big as one
patch to attempt to review it properly.  Would you like to review this
as-is?

thanks,

greg k-h