Re: [PATCH v4 1/3] dt-bindings: usb: add rk3588 compatible to rockchip,dwc3

[Sebastian Reichel]

Hi Rob,

On Sun, Oct 22, 2023 at 04:42:19PM -0500, Rob Herring wrote:
> On Fri, Oct 20, 2023 at 06:03:29PM +0200, Sebastian Reichel wrote:
> > On Fri, Oct 20, 2023 at 04:36:19PM +0100, Conor Dooley wrote:
> > > On Fri, Oct 20, 2023 at 04:11:40PM +0200, Sebastian Reichel wrote:
> > > > [...]
> > > > +allOf:
> > > > +  - $ref: snps,dwc3.yaml#
> > > > +  - if:
> > > > +      properties:
> > > > +        compatible:
> > > > +          contains:
> > > > +            const: rockchip,rk3328-dwc3
> > > > +    then:
> > > > +      properties:
> > > > +        clocks:
> > > > +          minItems: 3
> > > > +          maxItems: 4
> > > > +        clock-names:
> > > > +          minItems: 3
> > > > +          items:
> > > > +            - const: ref_clk
> > > > +            - const: suspend_clk
> > > > +            - const: bus_clk
> > > > +            - const: grf_clk
> > > 
> > > minItems for clocks and clock-names is already 3, is it not?
> > 
> > Yes, but the following 'maxItems: 4' implicitly sets it to 4,
> > so I had to set it again. The same is true for clock-names -
> > providings new 'items:' effectively drops the "minItems: 3"
> > from the generic section.
> 
> Are you sure? We don't add anything implicit in the if/then schemas. 
> Could be a tool issue though.

I had this issue in the past. But just in case I also did a re-test
before sending my last mail and I did get a warning. So yes, I'm
quite sure :)

-- Sebastian

Attachment: signature.asc
Description: PGP signature