Re: [PATCH 1/5] riscv: use ".L" local labels in assembly when applicable
From: Andrew Jones
Date: Mon Oct 23 2023 - 05:59:58 EST
On Wed, Oct 04, 2023 at 04:30:50PM +0200, Clément Léger wrote:
> For the sake of coherency, use local labels in assembly when
> applicable. This also avoid kprobes being confused when applying a
> kprobe since the size of function is computed by checking where the
> next visible symbol is located. This might end up in computing some
> function size to be way shorter than expected and thus failing to apply
> kprobes to the specified offset.
>
> Signed-off-by: Clément Léger <cleger@xxxxxxxxxxxx>
> ---
> arch/riscv/kernel/entry.S | 10 +++----
> arch/riscv/kernel/head.S | 18 ++++++-------
> arch/riscv/kernel/mcount.S | 10 +++----
> arch/riscv/lib/memmove.S | 54 +++++++++++++++++++-------------------
> 4 files changed, 46 insertions(+), 46 deletions(-)
>
Reviewed-by: Andrew Jones <ajones@xxxxxxxxxxxxxxxx>