Re: [PATCH v5 2/2] leds: ledtrig-tty: add new line mode evaluation

From: Greg KH
Date: Mon Oct 23 2023 - 08:27:39 EST


On Mon, Oct 23, 2023 at 02:15:55PM +0200, Florian Eckert wrote:
> > Again, I thought we had rx/tx already? If not, how was that controlled
> > today?
>
> It could not be controlled! The LED flashed when data where transferred.
> This was the only function that the trigger supported.

Ok, then maybe this needs to be a bit longer of a series. One that does
the "tx/rx" feature, as that is needed today, and will be the more
complex one, and then one-per-line-setting that you want to apply.

That should make it much easier to review overall, right?

thanks,

greg k-h