Re: [PATCH] drm/panel/raydium-rm692e5: select CONFIG_DRM_DISPLAY_DP_HELPER

[Konrad Dybcio]

On 23.10.2023 15:25, Neil Armstrong wrote:
> Hi,
> 
> On 23/10/2023 13:55, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@xxxxxxxx>
>>
>> As with several other panel drivers, this fails to link without the DP
>> helper library:
>>
>> ld: drivers/gpu/drm/panel/panel-raydium-rm692e5.o: in function `rm692e5_prepare':
>> panel-raydium-rm692e5.c:(.text+0x11f4): undefined reference to `drm_dsc_pps_payload_pack'
>>
>> Select the same symbols that the others already use.
>>
>> Fixes: 988d0ff29ecf7 ("drm/panel: Add driver for BOE RM692E5 AMOLED panel")
>> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
>> ---
>>   drivers/gpu/drm/panel/Kconfig | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
>> index 99e14dc212ecb..a4ac4b47777fe 100644
>> --- a/drivers/gpu/drm/panel/Kconfig
>> +++ b/drivers/gpu/drm/panel/Kconfig
>> @@ -530,6 +530,8 @@ config DRM_PANEL_RAYDIUM_RM692E5
>>       depends on OF
>>       depends on DRM_MIPI_DSI
>>       depends on BACKLIGHT_CLASS_DEVICE
>> +    select DRM_DISPLAY_DP_HELPER
>> +    select DRM_DISPLAY_HELPER
>>       help
>>         Say Y here if you want to enable support for Raydium RM692E5-based
>>         display panels, such as the one found in the Fairphone 5 smartphone.
> 
> Will apply once drm-misc-next-fixes is synced with the last drm-misc-next PR for v6.7.
Thanks Arnd, Neil.

Sounds like this helper should be extracted from DP specific code
in the future though, no?

Konrad