drivers/watchdog/mlx_wdt.c:55: warning: Function parameter or member 'regmap_val_sz' not described in 'mlxreg_wdt'
From: kernel test robot
Date: Mon Oct 23 2023 - 22:48:48 EST
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: e017769f4ce20dc0d3fa3220d4d359dcc4431274
commit: eee851143bca4422eeee3bb2e104b85537ba449d watchdog: mlx-wdt: support new watchdog type with longer timeout period
date: 3 years, 3 months ago
config: x86_64-randconfig-r013-20230824 (https://download.01.org/0day-ci/archive/20231024/202310241044.lvqeOGli-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231024/202310241044.lvqeOGli-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310241044.lvqeOGli-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
>> drivers/watchdog/mlx_wdt.c:55: warning: Function parameter or member 'regmap_val_sz' not described in 'mlxreg_wdt'
drivers/watchdog/mlx_wdt.c:55: warning: Function parameter or member 'wdt_type' not described in 'mlxreg_wdt'
vim +55 drivers/watchdog/mlx_wdt.c
c60923dd5feedc Michael Shych 2019-02-20 20
c60923dd5feedc Michael Shych 2019-02-20 21 #define MLXREG_WDT_CLOCK_SCALE 1000
c60923dd5feedc Michael Shych 2019-02-20 22 #define MLXREG_WDT_MAX_TIMEOUT_TYPE1 32
c60923dd5feedc Michael Shych 2019-02-20 23 #define MLXREG_WDT_MAX_TIMEOUT_TYPE2 255
eee851143bca44 Michael Shych 2020-05-04 24 #define MLXREG_WDT_MAX_TIMEOUT_TYPE3 65535
c60923dd5feedc Michael Shych 2019-02-20 25 #define MLXREG_WDT_MIN_TIMEOUT 1
c60923dd5feedc Michael Shych 2019-02-20 26 #define MLXREG_WDT_OPTIONS_BASE (WDIOF_KEEPALIVEPING | WDIOF_MAGICCLOSE | \
c60923dd5feedc Michael Shych 2019-02-20 27 WDIOF_SETTIMEOUT)
c60923dd5feedc Michael Shych 2019-02-20 28
c60923dd5feedc Michael Shych 2019-02-20 29 /**
c60923dd5feedc Michael Shych 2019-02-20 30 * struct mlxreg_wdt - wd private data:
c60923dd5feedc Michael Shych 2019-02-20 31 *
c60923dd5feedc Michael Shych 2019-02-20 32 * @wdd: watchdog device;
c60923dd5feedc Michael Shych 2019-02-20 33 * @device: basic device;
c60923dd5feedc Michael Shych 2019-02-20 34 * @pdata: data received from platform driver;
c60923dd5feedc Michael Shych 2019-02-20 35 * @regmap: register map of parent device;
c60923dd5feedc Michael Shych 2019-02-20 36 * @timeout: defined timeout in sec.;
c60923dd5feedc Michael Shych 2019-02-20 37 * @action_idx: index for direct access to action register;
c60923dd5feedc Michael Shych 2019-02-20 38 * @timeout_idx:index for direct access to TO register;
c60923dd5feedc Michael Shych 2019-02-20 39 * @tleft_idx: index for direct access to time left register;
c60923dd5feedc Michael Shych 2019-02-20 40 * @ping_idx: index for direct access to ping register;
c60923dd5feedc Michael Shych 2019-02-20 41 * @reset_idx: index for direct access to reset cause register;
c60923dd5feedc Michael Shych 2019-02-20 42 * @wd_type: watchdog HW type;
c60923dd5feedc Michael Shych 2019-02-20 43 */
c60923dd5feedc Michael Shych 2019-02-20 44 struct mlxreg_wdt {
c60923dd5feedc Michael Shych 2019-02-20 45 struct watchdog_device wdd;
c60923dd5feedc Michael Shych 2019-02-20 46 struct mlxreg_core_platform_data *pdata;
c60923dd5feedc Michael Shych 2019-02-20 47 void *regmap;
c60923dd5feedc Michael Shych 2019-02-20 48 int action_idx;
c60923dd5feedc Michael Shych 2019-02-20 49 int timeout_idx;
c60923dd5feedc Michael Shych 2019-02-20 50 int tleft_idx;
c60923dd5feedc Michael Shych 2019-02-20 51 int ping_idx;
c60923dd5feedc Michael Shych 2019-02-20 52 int reset_idx;
eee851143bca44 Michael Shych 2020-05-04 53 int regmap_val_sz;
c60923dd5feedc Michael Shych 2019-02-20 54 enum mlxreg_wdt_type wdt_type;
c60923dd5feedc Michael Shych 2019-02-20 @55 };
c60923dd5feedc Michael Shych 2019-02-20 56
:::::: The code at line 55 was first introduced by commit
:::::: c60923dd5feedc337b1450e3f4c6e19ffa305439 watchdog: mlx-wdt: introduce a watchdog driver for Mellanox systems.
:::::: TO: Michael Shych <michaelsh@xxxxxxxxxxxx>
:::::: CC: Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki