Re: [PATCH v13 09/10] arm64: dts: qcom: sa8295p: Enable tertiary controller and its 4 USB ports

[Johan Hovold]

On Mon, Oct 23, 2023 at 11:12:40PM +0530, Krishna Kurapati PSSNV wrote:
> On 10/23/2023 9:53 PM, Johan Hovold wrote:
> > On Sat, Oct 07, 2023 at 09:18:05PM +0530, Krishna Kurapati wrote:

> >> +	usb2_en_state: usb2-en-state {
> > 
> > No need to include '_state' in the labels.
> > 
> Any specific reason ? I have no problem if removing the suffix but just 
> wanted to know the reason.

For consistency with the rest of the sc8280xp devicetree sources
(including this file) where we've used that pattern (e.g. as reproducing
"state" in the label is mostly redundant). For example:

	pcie2a_default: pcie2a-default-state {}

and

	nvme_reg_en: nvme-reg-en-state {}

Johan