Re: [PATCH] vgacon: fix mips/sibyte build regression
From: Javier Martinez Canillas
Date: Tue Oct 24 2023 - 03:29:18 EST
Arnd Bergmann <arnd@xxxxxxxxxx> writes:
Hello Arnd,
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The conversion to vgacon_register_screen() was missing an #include statement
> for the swarm board:
>
> arch/mips/sibyte/swarm/setup.c:146:9: error: implicit declaration of function 'vgacon_register_screen' [-Werror=implicit-function-declaration]
>
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310240429.UqeQ2Cpr-lkp@xxxxxxxxx/
> Fixes: 555624c0d10b vgacon: clean up global screen_info instances
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
Loos good to me.
Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat