RE: [EXT] Re: [PATCH v6 1/6] wifi: mwifiex: added code to support host mlme.

From: David Lin
Date: Tue Oct 24 2023 - 03:30:45 EST




> -----Original Message-----
> From: Francesco Dolcini <francesco@xxxxxxxxxx>
> Sent: Monday, October 23, 2023 6:02 PM
> To: David Lin <yu-hao.lin@xxxxxxx>
> Cc: Francesco Dolcini <francesco@xxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; briannorris@xxxxxxxxxxxx; kvalo@xxxxxxxxxx;
> Sharvari Harisangam <sharvari.harisangam@xxxxxxx>; Pete Hsieh
> <tsung-hsien.hsieh@xxxxxxx>
> Subject: Re: [EXT] Re: [PATCH v6 1/6] wifi: mwifiex: added code to support host
> mlme.
>
> Caution: This is an external email. Please take care when clicking links or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>
>
> On Mon, Oct 23, 2023 at 02:16:26AM +0000, David Lin wrote:
> > > On Fri, Oct 20, 2023 at 03:48:11AM +0000, David Lin wrote:
> > > I noticed that you ignored some (all?) of my feedback [1].
> > >
> > > Maybe my feedback got lost between the quotes, maybe you just forgot
> > > to apply it. Please go back to the previous discussion and either
> > > implement all requested changes or keep discussing them.
> > >
> >
> > I think I replied your request and follow it. Please check following link:
> >
> > https://patc/
> >
> hwork.kernel.org%2Fproject%2Flinux-wireless%2Fpatch%2FPA4PR04MB9638DE
> F
> >
> C074F41AAEE3AC471D1DBA%40PA4PR04MB9638.eurprd04.prod.outlook.com
> %2F&da
> >
> ta=05%7C01%7Cyu-hao.lin%40nxp.com%7C6878af1bfd2840a79d0708dbd3af0c
> cb%7
> >
> C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C638336521007434968%
> 7CUnkno
> >
> wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiL
> >
> CJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=AMCnU6bzMXwCJcn0VqXPnUF
> xEQB8j8N4mF
> > 4LZchFxOA%3D&reserved=0
> >
> > Please press "Series: | expand", you will find cover letter with
> > related patches there. You can review any commit and reply the e-mail
> > separately. Thanks.
>
> I think we are not understanding each other, please have a look here
> https://lore.kern/
> el.org%2Fall%2FZRLsuJfxuvFk1K16%40francesco-nb.int.toradex.com%2F&data=
> 05%7C01%7Cyu-hao.lin%40nxp.com%7C6878af1bfd2840a79d0708dbd3af0ccb
> %7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63833652100743496
> 8%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLC
> JBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=amdyTVGXjQn
> js40yAAiVo3oN7pBEW5XmuG8UvNPNsyo%3D&reserved=0
> where you can find my comment on v4 of your series. I cannot find any answer
> to that comments nor the changes I asked for implemented.
>

Sorry. I missed lot of your comments on patch v4. I will check it and reply you. Any needed modifications will be added to Patch v7.

> Francesco