Re: [PATCH] ACPI: Rename acpi_scan_device_not_present() to be about enumeration

[Miguel Luis]

Hi Russell,

> On 24 Oct 2023, at 11:28, Russell King (Oracle) <linux@xxxxxxxxxxxxxxx> wrote:
> 
> On Tue, Oct 24, 2023 at 10:15:07AM +0000, Miguel Luis wrote:
>> Hi Russell,
>> 
>>> On 20 Oct 2023, at 18:47, Russell King <rmk+kernel@xxxxxxxxxxxxxxx> wrote:
>>> 
>>> From: James Morse <james.morse@xxxxxxx>
>>> 
>>> acpi_scan_device_not_present() is called when a device in the
>>> hierarchy is not available for enumeration. Historically enumeration
>>> was only based on whether the device was present.
>>> 
>>> To add support for only enumerating devices that are both present
>>> and enabled, this helper should be renamed. It was only ever about
>>> enumeration, rename it acpi_scan_device_not_enumerated().
>>> 
>>> No change in behaviour is intended.
>>> 
>>> Signed-off-by: James Morse <james.morse@xxxxxxx>
>>> Reviewed-by: Gavin Shan <gshan@xxxxxxxxxx>
>>> Signed-off-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
>> 
>> Fixes: 443fc8202272 ("ACPI / hotplug: Rework generic code to handle suprise removals”) ?
> 
> I'm not sure a patch that is merely renaming a function should ever
> have a Fixes tag, since it's just a naming issue, it doesn't fix a
> bug, change functionality or anything like that.
> 
> I would suggest that there would need to be good reason why such a
> patch should be backported to stable kernels - for example, something
> else that does fix a user visible bug requires this change.
> 

Understood. Thanks for clarifying!

Miguel

> Thanks.
> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!