Re: [RFC PATCH 1/2] serial: core: Move tty and serdev to be children of serial core port device
From: Andy Shevchenko
Date: Tue Oct 24 2023 - 08:44:00 EST
On Tue, Oct 24, 2023 at 03:17:26PM +0300, Andy Shevchenko wrote:
> On Tue, Oct 24, 2023 at 02:36:18PM +0300, Tony Lindgren wrote:
...
> > - ctrl->dev.of_node = parent->of_node;
> > + ctrl->dev.of_node = host->of_node;
>
> Even above should have been using device_set_node(&ctrl->dev, dev_fwnode(host)).
...
> > /* Make sure controller and ResourceSource handle match */
> > - if (ACPI_HANDLE(ctrl->dev.parent) != lookup.controller_handle)
> > + if (ACPI_HANDLE(ctrl->host) != lookup.controller_handle)
>
> This can be changed to use device_match_acpi_handle().
>
> > return -ENODEV;
...
> > - if (!has_acpi_companion(ctrl->dev.parent))
> > + if (!has_acpi_companion(ctrl->host))
>
> I prefer is_acpi_device_node(dev_fwnode(...)) check, but here seems no other
> use for fwnode (haven't checked the full context, though).
>
> > return -ENODEV;
...
I have just sent a little series based on these comments.
--
With Best Regards,
Andy Shevchenko