Re: [PATCH v2 2/2] regulator: fixed: add support for under-voltage IRQ

From: Mark Brown
Date: Tue Oct 24 2023 - 09:36:43 EST


On Tue, Oct 24, 2023 at 03:08:42PM +0200, Oleksij Rempel wrote:

> Add interrupt support for under-voltage notification. This functionality
> can be used on systems capable to detect under-voltage state and having
> enough capacity to let the SoC do some emergency preparation.
>
> This change enforce default policy to shutdown system as soon as
> interrupt is triggered.

...

> +static irqreturn_t reg_fixed_under_voltage_irq_handler(int irq, void *data)
> +{
> + hw_protection_shutdown("Critical voltage drop reached",
> + FV_DEF_EMERG_SHUTDWN_TMO);
> +
> + return IRQ_HANDLED;
> +}

We need a bit more policy here - the regulator could be critical to
system function but it could also be well isolated and just affecting
whatever device it's directly supplying in a way that the system can
tolerate and might even want to (eg, for something like a SD card or USB
port where end users are plugging in external hardware).

Attachment: signature.asc
Description: PGP signature