Re: [RFC PATCH 1/2] serial: core: Move tty and serdev to be children of serial core port device

From: Tony Lindgren
Date: Tue Oct 24 2023 - 09:39:12 EST


* Johan Hovold <johan@xxxxxxxxxx> [231024 12:48]:
> Looks like this patch breaks the wakeup-irq hack in uart_suspend_port():
>
> tty_dev = device_find_child(uport->dev, &match, serial_match_port);
> if (tty_dev && device_may_wakeup(tty_dev)) {
> enable_irq_wake(uport->irq);
> put_device(tty_dev);
> mutex_unlock(&port->mutex);
> return 0;
> }
>
> There may be more of these hard-coded assumptions, this one I happened
> to be aware of.

OK thanks I'll take a look.

Regards,

Tony