Re: [PATCH V2] ACPI: APEI: Use ERST timeout for slow devices
From: Borislav Petkov
Date: Tue Oct 24 2023 - 11:27:55 EST
On Tue, Oct 24, 2023 at 04:32:48PM +0200, Rafael J. Wysocki wrote:
> So there are 3 designated reviewers for APEI: Tony Luck, Borislav
> Petkov and James Morse. I need an ACK or Reviewed-by from one of
> them, so I can proceed with an APEI patch.
Here's what I see:
cat /tmp/patch | ./scripts/get_maintainer.pl
Kees Cook <keescook@xxxxxxxxxxxx> (supporter:PSTORE FILESYSTEM)
Tony Luck <tony.luck@xxxxxxxxx> (reviewer:PSTORE FILESYSTEM)
"Guilherme G. Piccoli" <gpiccoli@xxxxxxxxxx> (reviewer:PSTORE FILESYSTEM)
"Rafael J. Wysocki" <rafael@xxxxxxxxxx> (unknown:ACPI APEI)
Len Brown <lenb@xxxxxxxxxx> (reviewer:ACPI APEI)
James Morse <james.morse@xxxxxxx> (reviewer:ACPI APEI)
Borislav Petkov <bp@xxxxxxxxx> (reviewer:ACPI APEI)
so I'm guessing Kees, Tony, Guilherme ...
>From what I can see, the change itself is making me ask more questions:
When I see "may" in commit messages "Slow devices such as flash may not
meet the default 1ms timeout value" then I wanna know what devices are
those?
What is the actual use case here?
Upthread there's a question about the ACPI spec. That should be
explained too. Because I have no clue what "the ERST max execution time
value" is.
And so on.
HTH.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette