Re: [PATCH] ath10k: replace deprecated strncpy with strtomem_pad

[Jeff Johnson]

On 10/24/2023 2:43 PM, Kees Cook wrote:
> On Tue, Oct 24, 2023 at 07:11:51AM -0700, Jeff Johnson wrote:
> > On 10/24/2023 6:03 AM, Kalle Valo wrote:
> > > What about using just memcpy() to make it clear it's not really a proper
> > > string:
> > >
> > > arvif->u.ap.ssid_len = 4;
> > > memcpy(arvif->u.ap.ssid, "mesh", arvif->u.ap.ssid_len);
> >
> > In the "changed & BSS_CHANGED_SSID" case that comes soon after this we just
> > set the length and use memcpy without clearing the rest of the buffer, so
> > doing the same here, as you suggest, would be consistent.
>
> Ah, please ignore my other email asking about memcpy safety -- I'm
> reading threads backwards.  :)
And I'm replying without first reading through my mail queue