Re: [PATCH v3 0/6] Refine _UID references across kernel

From: Guenter Roeck
Date: Tue Oct 24 2023 - 22:05:19 EST


On Tue, Oct 24, 2023 at 09:51:08PM +0200, Rafael J. Wysocki wrote:
> On Tue, Oct 24, 2023 at 11:30 AM Mika Westerberg
> <mika.westerberg@xxxxxxxxxxxxxxx> wrote:
> >
> > On Tue, Oct 24, 2023 at 11:50:12AM +0530, Raag Jadav wrote:
> > > This series refines _UID references across kernel by:
> > >
> > > - Extracting _UID matching functionality from acpi_dev_hid_uid_match()
> > > helper and introducing it as a separate acpi_dev_uid_match() helper.
> > >
> > > - Converting manual _UID references to use the standard ACPI helpers.
> > >
> > > Changes since v2:
> > > - Drop review tags as suggested by Andy.
> > >
> > > Changes since v1:
> > > - Change acpi_dev_uid_match() to return false in case of NULL argument.
> > > - Drop accepted patches.
> > >
> > > Raag Jadav (6):
> > > ACPI: utils: Introduce acpi_dev_uid_match() for matching _UID
> > > pinctrl: intel: use acpi_dev_uid_match() for matching _UID
> > > ACPI: utils: use acpi_dev_uid_match() for matching _UID
> > > ACPI: x86: use acpi_dev_uid_match() for matching _UID
> > > hwmon: nct6775: use acpi_dev_hid_uid_match() for matching _HID and
> > > _UID
> > > perf: arm_cspmu: use acpi_dev_hid_uid_match() for matching _HID and
> > > _UID
> >
> > For the series,
> >
> > Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
> >
> > > drivers/acpi/utils.c | 34 ++++++++++++++++++++++-----
> > > drivers/acpi/x86/utils.c | 3 +--
> > > drivers/hwmon/nct6775-platform.c | 4 +---
> > > drivers/perf/arm_cspmu/arm_cspmu.c | 8 +++----
> > > drivers/pinctrl/intel/pinctrl-intel.c | 2 +-
> >
> > This pinctrl one is also fine by me so if Andy does not have objections,
> > feel free to add my,
> >
> > Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
>
> Whole series applied as 6.7 material with tags as per the above, thanks!

Ok, that means I will _not_ apply the hwmon patch through
the hwmon tree.

FWIW, please note that I would have very much preferred applying
it through the hwmon tree, and I did _not_ Ack it.

Guenter