Re: [PATCH v17 03/12] block: add copy offload support
From: Dan Carpenter
Date: Wed Oct 25 2023 - 00:45:25 EST
Hi Nitesh,
kernel test robot noticed the following build warnings:
url: https://github.com/intel-lab-lkp/linux/commits/Nitesh-Shetty/block-Introduce-queue-limits-and-sysfs-for-copy-offload-support/20231019-200658
base: 213f891525c222e8ed145ce1ce7ae1f47921cb9c
patch link: https://lore.kernel.org/r/20231019110147.31672-4-nj.shetty%40samsung.com
patch subject: [PATCH v17 03/12] block: add copy offload support
config: i386-randconfig-141-20231022 (https://download.01.org/0day-ci/archive/20231025/202310251059.GiTmwLYx-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20231025/202310251059.GiTmwLYx-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
| Closes: https://lore.kernel.org/r/202310251059.GiTmwLYx-lkp@xxxxxxxxx/
New smatch warnings:
block/blk-lib.c:248 blkdev_copy_offload() warn: use 'gfp' here instead of GFP_KERNEL?
Old smatch warnings:
block/blk-lib.c:264 blkdev_copy_offload() warn: use 'gfp' here instead of GFP_KERNEL?
vim +/gfp +248 block/blk-lib.c
391929a15e2c18 Nitesh Shetty 2023-10-19 228 ssize_t blkdev_copy_offload(struct block_device *bdev, loff_t pos_in,
391929a15e2c18 Nitesh Shetty 2023-10-19 229 loff_t pos_out, size_t len,
391929a15e2c18 Nitesh Shetty 2023-10-19 230 void (*endio)(void *, int, ssize_t),
391929a15e2c18 Nitesh Shetty 2023-10-19 231 void *private, gfp_t gfp)
391929a15e2c18 Nitesh Shetty 2023-10-19 232 {
391929a15e2c18 Nitesh Shetty 2023-10-19 233 struct blkdev_copy_io *cio;
391929a15e2c18 Nitesh Shetty 2023-10-19 234 struct blkdev_copy_offload_io *offload_io;
391929a15e2c18 Nitesh Shetty 2023-10-19 235 struct bio *src_bio, *dst_bio;
391929a15e2c18 Nitesh Shetty 2023-10-19 236 size_t rem, chunk;
391929a15e2c18 Nitesh Shetty 2023-10-19 237 size_t max_copy_bytes = bdev_max_copy_sectors(bdev) << SECTOR_SHIFT;
391929a15e2c18 Nitesh Shetty 2023-10-19 238 ssize_t ret;
391929a15e2c18 Nitesh Shetty 2023-10-19 239 struct blk_plug plug;
391929a15e2c18 Nitesh Shetty 2023-10-19 240
391929a15e2c18 Nitesh Shetty 2023-10-19 241 if (!max_copy_bytes)
391929a15e2c18 Nitesh Shetty 2023-10-19 242 return -EOPNOTSUPP;
391929a15e2c18 Nitesh Shetty 2023-10-19 243
391929a15e2c18 Nitesh Shetty 2023-10-19 244 ret = blkdev_copy_sanity_check(bdev, pos_in, bdev, pos_out, len);
391929a15e2c18 Nitesh Shetty 2023-10-19 245 if (ret)
391929a15e2c18 Nitesh Shetty 2023-10-19 246 return ret;
391929a15e2c18 Nitesh Shetty 2023-10-19 247
391929a15e2c18 Nitesh Shetty 2023-10-19 @248 cio = kzalloc(sizeof(*cio), GFP_KERNEL);
Should this be: cio = kzalloc(sizeof(*cio), gfp);? It's not totally
clear from the context honestly. (I haven't looked at the code outside
what is in this automated email).
391929a15e2c18 Nitesh Shetty 2023-10-19 249 if (!cio)
391929a15e2c18 Nitesh Shetty 2023-10-19 250 return -ENOMEM;
391929a15e2c18 Nitesh Shetty 2023-10-19 251 atomic_set(&cio->refcount, 1);
391929a15e2c18 Nitesh Shetty 2023-10-19 252 cio->waiter = current;
391929a15e2c18 Nitesh Shetty 2023-10-19 253 cio->endio = endio;
391929a15e2c18 Nitesh Shetty 2023-10-19 254 cio->private = private;
391929a15e2c18 Nitesh Shetty 2023-10-19 255
391929a15e2c18 Nitesh Shetty 2023-10-19 256 /*
391929a15e2c18 Nitesh Shetty 2023-10-19 257 * If there is a error, copied will be set to least successfully
391929a15e2c18 Nitesh Shetty 2023-10-19 258 * completed copied length
391929a15e2c18 Nitesh Shetty 2023-10-19 259 */
391929a15e2c18 Nitesh Shetty 2023-10-19 260 cio->copied = len;
391929a15e2c18 Nitesh Shetty 2023-10-19 261 for (rem = len; rem > 0; rem -= chunk) {
391929a15e2c18 Nitesh Shetty 2023-10-19 262 chunk = min(rem, max_copy_bytes);
391929a15e2c18 Nitesh Shetty 2023-10-19 263
391929a15e2c18 Nitesh Shetty 2023-10-19 264 offload_io = kzalloc(sizeof(*offload_io), GFP_KERNEL);
391929a15e2c18 Nitesh Shetty 2023-10-19 265 if (!offload_io)
391929a15e2c18 Nitesh Shetty 2023-10-19 266 goto err_free_cio;
391929a15e2c18 Nitesh Shetty 2023-10-19 267 offload_io->cio = cio;
391929a15e2c18 Nitesh Shetty 2023-10-19 268 /*
391929a15e2c18 Nitesh Shetty 2023-10-19 269 * For partial completion, we use offload_io->offset to truncate
391929a15e2c18 Nitesh Shetty 2023-10-19 270 * successful copy length
391929a15e2c18 Nitesh Shetty 2023-10-19 271 */
391929a15e2c18 Nitesh Shetty 2023-10-19 272 offload_io->offset = len - rem;
391929a15e2c18 Nitesh Shetty 2023-10-19 273
391929a15e2c18 Nitesh Shetty 2023-10-19 274 src_bio = bio_alloc(bdev, 0, REQ_OP_COPY_SRC, gfp);
391929a15e2c18 Nitesh Shetty 2023-10-19 275 if (!src_bio)
391929a15e2c18 Nitesh Shetty 2023-10-19 276 goto err_free_offload_io;
391929a15e2c18 Nitesh Shetty 2023-10-19 277 src_bio->bi_iter.bi_size = chunk;
391929a15e2c18 Nitesh Shetty 2023-10-19 278 src_bio->bi_iter.bi_sector = pos_in >> SECTOR_SHIFT;
391929a15e2c18 Nitesh Shetty 2023-10-19 279
391929a15e2c18 Nitesh Shetty 2023-10-19 280 blk_start_plug(&plug);
391929a15e2c18 Nitesh Shetty 2023-10-19 281 dst_bio = blk_next_bio(src_bio, bdev, 0, REQ_OP_COPY_DST, gfp);
391929a15e2c18 Nitesh Shetty 2023-10-19 282 if (!dst_bio)
391929a15e2c18 Nitesh Shetty 2023-10-19 283 goto err_free_src_bio;
391929a15e2c18 Nitesh Shetty 2023-10-19 284 dst_bio->bi_iter.bi_size = chunk;
391929a15e2c18 Nitesh Shetty 2023-10-19 285 dst_bio->bi_iter.bi_sector = pos_out >> SECTOR_SHIFT;
391929a15e2c18 Nitesh Shetty 2023-10-19 286 dst_bio->bi_end_io = blkdev_copy_offload_dst_endio;
391929a15e2c18 Nitesh Shetty 2023-10-19 287 dst_bio->bi_private = offload_io;
391929a15e2c18 Nitesh Shetty 2023-10-19 288
391929a15e2c18 Nitesh Shetty 2023-10-19 289 atomic_inc(&cio->refcount);
391929a15e2c18 Nitesh Shetty 2023-10-19 290 submit_bio(dst_bio);
391929a15e2c18 Nitesh Shetty 2023-10-19 291 blk_finish_plug(&plug);
391929a15e2c18 Nitesh Shetty 2023-10-19 292 pos_in += chunk;
391929a15e2c18 Nitesh Shetty 2023-10-19 293 pos_out += chunk;
391929a15e2c18 Nitesh Shetty 2023-10-19 294 }
391929a15e2c18 Nitesh Shetty 2023-10-19 295
391929a15e2c18 Nitesh Shetty 2023-10-19 296 if (atomic_dec_and_test(&cio->refcount))
391929a15e2c18 Nitesh Shetty 2023-10-19 297 blkdev_copy_endio(cio);
391929a15e2c18 Nitesh Shetty 2023-10-19 298 if (endio)
391929a15e2c18 Nitesh Shetty 2023-10-19 299 return -EIOCBQUEUED;
391929a15e2c18 Nitesh Shetty 2023-10-19 300
391929a15e2c18 Nitesh Shetty 2023-10-19 301 return blkdev_copy_wait_for_completion_io(cio);
391929a15e2c18 Nitesh Shetty 2023-10-19 302
391929a15e2c18 Nitesh Shetty 2023-10-19 303 err_free_src_bio:
391929a15e2c18 Nitesh Shetty 2023-10-19 304 bio_put(src_bio);
391929a15e2c18 Nitesh Shetty 2023-10-19 305 err_free_offload_io:
391929a15e2c18 Nitesh Shetty 2023-10-19 306 kfree(offload_io);
391929a15e2c18 Nitesh Shetty 2023-10-19 307 err_free_cio:
391929a15e2c18 Nitesh Shetty 2023-10-19 308 cio->copied = min_t(ssize_t, cio->copied, (len - rem));
391929a15e2c18 Nitesh Shetty 2023-10-19 309 cio->status = -ENOMEM;
391929a15e2c18 Nitesh Shetty 2023-10-19 310 if (rem == len) {
391929a15e2c18 Nitesh Shetty 2023-10-19 311 ret = cio->status;
391929a15e2c18 Nitesh Shetty 2023-10-19 312 kfree(cio);
391929a15e2c18 Nitesh Shetty 2023-10-19 313 return ret;
391929a15e2c18 Nitesh Shetty 2023-10-19 314 }
391929a15e2c18 Nitesh Shetty 2023-10-19 315 if (cio->endio)
391929a15e2c18 Nitesh Shetty 2023-10-19 316 return cio->status;
391929a15e2c18 Nitesh Shetty 2023-10-19 317
391929a15e2c18 Nitesh Shetty 2023-10-19 318 return blkdev_copy_wait_for_completion_io(cio);
391929a15e2c18 Nitesh Shetty 2023-10-19 319 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki