Re: [PATCH v2 0/3] nvme-tcp: always set valid seq_num in dhchap reply

[Hannes Reinecke]

On 10/24/23 18:40, Keith Busch wrote:
> On Mon, Oct 23, 2023 at 02:00:00PM +0000, Mark O'Donovan wrote:
> > The first patch is a small unrelated fix which makes it clear that the
> > response data section of the Success1 message is not optional.
> >
> > The second patch removes use of the host sequence number (S2) as an
> > indicator of bi-directional authentication.
> >
> > The third patch causes us to always set the host sequence number (S2)
> > to a non-zero value instead of the 0 value reserved for the secure
> > channel feature.
>
> Should these go in now for 6.6? We're pretty close to the end. If for
> 6.7, there is a merge conflict that I think would be easiest resolved if
> I wait until the block tree resyncs after the 6.7 merge window opens.
I'd suggest to wait, as we'll need to fixup nvmet, too.

Cheers,

Hannes
--
Dr. Hannes Reinecke                Kernel Storage Architect
hare@xxxxxxx                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Ivo Totev, Andrew
Myers, Andrew McDonald, Martje Boudien Moerman