Re: [PATCH] riscv: boot: Fix creation of loader.bin

From: Damien Le Moal
Date: Wed Oct 25 2023 - 03:27:52 EST


On 10/24/23 23:53, Geert Uytterhoeven wrote:
> When flashing loader.bin for K210 using kflash:
>
>     [ERROR] This is an ELF file and cannot be programmed to flash directly: arch/riscv/boot/loader.bin
>
> Before, loader.bin relied on "OBJCOPYFLAGS := -O binary" in the main
> RISC-V Makefile to create a boot image with the right format. With this
> removed, the image is now created in the wrong (ELF) format.
>
> Fix this by adding an explicit rule.
>
> Fixes: 505b02957e74f0c5 ("riscv: Remove duplicate objcopy flag")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Looks OK to me.

Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>

--
Damien Le Moal
Western Digital Research