Re: [PATCH v2 05/11] drm/mediatek: Add mtk_ddp_sec_write to config secure buffer info

[Jason-JH Lin (林睿祥)]

Hi Angelo,

Thanks for the reviews.

On Tue, 2023-10-24 at 10:37 +0200, AngeloGioacchino Del Regno wrote:
> Il 23/10/23 06:45, Jason-JH.Lin ha scritto:
> > Add mtk_ddp_sec_write to configure secure buffer information to
> > cmdq secure packet data.
> > Then secure cmdq driver will use these information to configure
> > curresponding secure DRAM address to HW overlay in secure world.
> > 
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx>
> > ---
> >   drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 12 ++++++++++++
> >   drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h |  4 ++++
> >   2 files changed, 16 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> > b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> > index 771f4e173353..3dca936b9143 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
> > @@ -111,6 +111,18 @@ void mtk_ddp_write_mask(struct cmdq_pkt
> > *cmdq_pkt, unsigned int value,
> >   #endif
> >   }
> >   
> > +void mtk_ddp_sec_write(struct cmdq_pkt *cmdq_pkt, u32 addr, u64
> > base,
> > +		       const enum cmdq_iwc_addr_metadata_type type,
> > +		       const u32 offset, const u32 size, const u32
> > port)
> > +{
> > +#if IS_REACHABLE(CONFIG_MTK_CMDQ)
> > +	/* secure buffer will be 4K alignment */
> > +	if (cmdq_pkt)
> 
> 	if (!cmdq_pkt)
> 		return;
> 	cmdq_sec_pkt_write....
> 
OK, I'll change it.

Regards,
Jason-JH.Lin

> Regards,
> Angelo
> 
> 
>