Re: [PATCH 2/3] pinctrl: qcom: handle intr_target_reg wakeup_present/enable bits

From: Krzysztof Kozlowski
Date: Wed Oct 25 2023 - 04:16:28 EST


On 25/10/2023 09:33, Neil Armstrong wrote:
> New platforms uses a new set of bits to control the wakeirq
> delivery to the PDC block.
>
> The intr_wakeup_present_bit indicates if the GPIO supports
> wakeirq and intr_wakeup_enable_bit enables wakeirq delivery
> to the PDC block.
>
> While the name seems to imply this only enables wakeup events,
> it is required to allow interrupts events to the PDC block.
>
> Enable this bit in the irq resource request/free if:
> - gpio is in wakeirq map
> - has the intr_wakeup_present_bit
> - the intr_wakeup_enable_bit is set
>
> Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>
> ---

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof