Re: [PATCH v4] vsock/virtio: initialize the_virtio_vsock before using VQs

[Stefano Garzarella]

On Tue, Oct 24, 2023 at 10:17:42PM +0300, Alexandru Matei wrote:
> Once VQs are filled with empty buffers and we kick the host, it can send
> connection requests. If the_virtio_vsock is not initialized before,
> replies are silently dropped and do not reach the host.
>
> virtio_transport_send_pkt() can queue packets once the_virtio_vsock is
> set, but they won't be processed until vsock->tx_run is set to true. We
> queue vsock->send_pkt_work when initialization finishes to send those
> packets queued earlier.
>
> Fixes: 0deab087b16a ("vsock/virtio: use RCU to avoid use-after-free on the_virtio_vsock")
> Signed-off-by: Alexandru Matei <alexandru.matei@xxxxxxxxxx>
> ---
> v4:
> - moved queue_work for send_pkt_work in vqs_start and added comment explaining why
> v3:
> - renamed vqs_fill to vqs_start and moved tx_run initialization to it
> - queued send_pkt_work at the end of initialization to send packets queued earlier
> v2:
> - split virtio_vsock_vqs_init in vqs_init and vqs_fill and moved
>  the_virtio_vsock initialization after vqs_init
>
> net/vmw_vsock/virtio_transport.c | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)

LGTM!

Reviewed-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>